Upload docker image to ECR during feast apply #1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixwang9817
requested review from
achals,
adchia,
woop and
a team
as code owners
woop
reviewed
Sep 17, 2021
woop
reviewed
Sep 17, 2021
Codecov Report
@@ Coverage Diff @@
## master #1877 +/- ##
==========================================
- Coverage 83.73% 83.31% -0.42%
==========================================
Files 96 96
Lines 7353 7482 +129
==========================================
+ Hits 6157 6234 +77
- Misses 1196 1248 +52
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
woop
reviewed
Sep 17, 2021
woop
reviewed
Sep 17, 2021
woop
reviewed
Sep 17, 2021
tsotnet
requested changes
Sep 17, 2021
Signed-off-by: Felix Wang <[email protected]>
felixwang9817
force-pushed
the
docker_image_to_ecr
branch
from
641efdc
to
294ad10
Compare
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
tsotnet
reviewed
Sep 22, 2021
Signed-off-by: Felix Wang <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: felixwang9817, tsotnet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Felix Wang [email protected]
What this PR does / why we need it: This PR pulls the AWS Lambda feature server docker image and uploads it to AWS ECR during feast apply.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: